Re: [openss7] Hey

["Brian F. G. Bidulock" <bidulock@openss7.org>]

Chuck,

Attached patch will shut fast retrans calc up for you.

--Brian

Chuck Winters wrote:                                          Mon, 18 Jun 2001 18:06:40
> Brian,
>     Sorry, for the delay, but I was busy testing a protocol!  It does
> work.  The times seem to be good so far on a small sample size.  There
> are a couple of problems though.
> 
>     1)  sctp_fast_retrans_calc is not passing a debugging feature on
> line 202
>     2)  recvmsg does not return anything in (struct
> msghdr).msg_name (it's null)
>     3)  Something locks up when there is a packet size of 4096.  It
> locks up after about 5 messages are sent
>           of that size
> 
>     I just started a run on 1,000,000 messages, so we'll see what
> happens.  The max. data size will be 2048 bytes, so it doesn't lock up.
> 
>     I still have to implement the rtt stuff into my code.  Maybe
> tomorrow I will start that so I can begin to tweak some settings.
> 
> Later,
> Chuck

-- 
Brian F. G. Bidulock    ¦ The reasonable man adapts himself to the ¦
bidulock@openss7.org    ¦ world; the unreasonable one persists in  ¦
http://www.openss7.org/ ¦ trying  to adapt the  world  to himself. ¦
                        ¦ Therefore  all  progress  depends on the ¦
                        ¦ unreasonable man. -- George Bernard Shaw ¦
Index: sctp_input.c
===================================================================
RCS file: /home/common/cvsroot/linux/net/ipv4/sctp_input.c,v
retrieving revision 1.41
retrieving revision 1.42
diff -c -r1.41 -r1.42
*** sctp_input.c	2001/06/11 16:58:36	1.41
--- sctp_input.c	2001/06/18 22:27:01	1.42
***************
*** 1,6 ****
  /*****************************************************************************
  
!  @(#) $Id: sctp_input.c,v 1.41 2001/06/11 16:58:36 brian Exp $
  
   -----------------------------------------------------------------------------
  
--- 1,6 ----
  /*****************************************************************************
  
!  @(#) $Id: sctp_input.c,v 1.42 2001/06/18 22:27:01 brian Exp $
  
   -----------------------------------------------------------------------------
  
***************
*** 24,32 ****
  
   -----------------------------------------------------------------------------
  
!  Last Modified $Date: 2001/06/11 16:58:36 $ by $Author: brian $
  
   $Log: sctp_input.c,v $
   Revision 1.41  2001/06/11 16:58:36  brian
   Fixed RTT calc problem reported by Chuck Winters.
  
--- 24,35 ----
  
   -----------------------------------------------------------------------------
  
!  Last Modified $Date: 2001/06/18 22:27:01 $ by $Author: brian $
  
   $Log: sctp_input.c,v $
+  Revision 1.42  2001/06/18 22:27:01  brian
+  Suppressed fast retrans calc when no gaps.
+ 
   Revision 1.41  2001/06/11 16:58:36  brian
   Fixed RTT calc problem reported by Chuck Winters.
  
***************
*** 101,107 ****
  
   *****************************************************************************/
  
! static char const ident[] = "$Name:  $($Revision: 1.41 $) $Date: 2001/06/11 16:58:36 $";
  
  /*
   *  ==========================================================================
--- 104,110 ----
  
   *****************************************************************************/
  
! static char const ident[] = "$Name:  $($Revision: 1.42 $) $Date: 2001/06/18 22:27:01 $";
  
  /*
   *  ==========================================================================
***************
*** 750,755 ****
--- 753,759 ----
  	sctp_rcv_ack(sk, ack, buf);
  
  	/* perform fast retransmission algorithm */
+         if ( ngaps )
  	{
  		struct sctp_daddr *df = NULL;	/* dest for Fast Retransmit */
  		struct sk_buff *skb;
***************
*** 806,813 ****
  				SCTP_SKB_CB(skb)->flags |= SCTPCB_FLAG_SACKED;
  			}
  		}
! 		/* RFC 2960 7.2.4 (2) */
! 		sctp_fast_retrans_calc(df);
  	}
  	{
  		int ret;
--- 810,818 ----
  				SCTP_SKB_CB(skb)->flags |= SCTPCB_FLAG_SACKED;
  			}
  		}
!                 if ( df )
!                         /* RFC 2960 7.2.4 (2) */
!                         sctp_fast_retrans_calc(df);
  	}
  	{
  		int ret;